netdev - Re: [RFC PATCH v7 2/8] dpll: Add DPLL framework base functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c888b44da3235c8405d890c51d77f064d84fd5f.camel@redhat.com>
Date: Mon, 22 May 2023 16:45:29 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Vadim Fedorenko <vadfed@...a.com>, Jakub Kicinski <kuba@...nel.org>, 
 Jiri Pirko <jiri@...nulli.us>, Arkadiusz Kubalewski
 <arkadiusz.kubalewski@...el.com>, Jonathan Lemon <jonathan.lemon@...il.com>
Cc: Milena Olech <milena.olech@...el.com>, Michal Michalik
 <michal.michalik@...el.com>, linux-arm-kernel@...ts.infradead.org, Vadim
 Fedorenko <vadim.fedorenko@...ux.dev>, poros@...hat.com,
 mschmidt@...hat.com, netdev@...r.kernel.org,  linux-clk@...r.kernel.org
Subject: Re: [RFC PATCH v7 2/8] dpll: Add DPLL framework base functions

On Thu, 2023-04-27 at 17:20 -0700, Vadim Fedorenko wrote:
> From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> 
> DPLL framework is used to represent and configure DPLL devices
> in systems. Each device that has DPLL and can configure sources
> and outputs can use this framework. Netlink interface is used to
> provide configuration data and to receive notification messages
> about changes in the configuration or status of DPLL device.
> Inputs and outputs of the DPLL device are represented as special
> objects which could be dynamically added to and removed from DPLL
> device.
> 
> Co-developed-by: Milena Olech <milena.olech@...el.com>
> Signed-off-by: Milena Olech <milena.olech@...el.com>
> Co-developed-by: Michal Michalik <michal.michalik@...el.com>
> Signed-off-by: Michal Michalik <michal.michalik@...el.com>
> Co-developed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>

As this patch is quite big and tend to accumulate quite a few comments
- both hard to track and to address - I'm wondering if splitting it in
a few separated patches would could help?

e.g. 

- 1 patch for dpll device struct && APIs definition
- 1 patch for pin related APIs
- 1 patch for netlink notification.

(to be considered only if the effort for the above split is not
overwhelming)

Possibly the same could apply to patch 5/8.

Cheers,

Paolo