lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJ8uoz30j7axJ+jd4UC4v57SBBBExbshQk7EZo-+bvPHOmcbSw@mail.gmail.com> Date: Mon, 22 May 2023 17:27:27 +0200 From: Magnus Karlsson <magnus.karlsson@...il.com> To: Alexander Lobakin <aleksander.lobakin@...el.com> Cc: Jakub Kicinski <kuba@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org>, Larysa Zaremba <larysa.zaremba@...el.com>, netdev@...r.kernel.org, Ilias Apalodimas <ilias.apalodimas@...aro.org>, linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>, Eric Dumazet <edumazet@...gle.com>, Michal Kubiak <michal.kubiak@...el.com>, intel-wired-lan@...ts.osuosl.org, Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>, Magnus Karlsson <magnus.karlsson@...el.com> Subject: Re: [Intel-wired-lan] [PATCH net-next 07/11] net: page_pool: add DMA-sync-for-CPU inline helpers On Mon, 22 May 2023 at 15:50, Alexander Lobakin <aleksander.lobakin@...el.com> wrote: > > From: Jakub Kicinski <kuba@...nel.org> > Date: Fri, 19 May 2023 13:45:45 -0700 > > > On Fri, 19 May 2023 15:56:40 +0200 Alexander Lobakin wrote: > >> From: Jakub Kicinski <kuba@...nel.org> > >> Date: Thu, 18 May 2023 13:36:27 -0700 > > [...] > > > Ack, not saying that we need to split now, it's just about the naming > > (everyone's favorite topic). > > > > I think that it's a touch weird to name the header _drv.h and then > > include it in the core in multiple places (*cough* xdp_sock_drv.h). > > Hahaha, I also thought of it :> Haha! Point taken. Will clear it up. > > Also If someone needs to add another "heavy" static line for use by > > the core they will try to put it in page_pool.h rather than _drv.h... > > > > I'd rather split the includes by the basic language-level contents, > > first, then by the intended consumer, only if necessary. Language > > level sorting require less thinking :) > > > > But none of this is important, if you don't wanna to do it, just keep > > the new helpers in page_pool.h (let's not do another _drv.h). > > Ack, will just put there. It doesn't get included by the whole kernel > via skbuff.h anymore (in v2), so new inlines won't hurt. > > Thanks, > Olek > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@...osl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Powered by blists - more mailing lists