lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <21522575-f6ef-5c8b-4a0a-0f2c208afa66@intel.com> Date: Mon, 22 May 2023 17:36:49 +0200 From: Alexander Lobakin <aleksander.lobakin@...el.com> To: Larysa Zaremba <larysa.zaremba@...el.com> CC: <bpf@...r.kernel.org>, Stanislav Fomichev <sdf@...gle.com>, "Alexei Starovoitov" <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Jakub Kicinski <kuba@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, "KP Singh" <kpsingh@...nel.org>, Jiri Olsa <jolsa@...nel.org>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, Anatoly Burakov <anatoly.burakov@...el.com>, Jesper Dangaard Brouer <brouer@...hat.com>, Alexander Lobakin <alexandr.lobakin@...el.com>, "Magnus Karlsson" <magnus.karlsson@...il.com>, Maryam Tahhan <mtahhan@...hat.com>, <xdp-hints@...-project.net>, <netdev@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH RESEND bpf-next 01/15] ice: make RX hash reading code more reusable From: Larysa Zaremba <larysa.zaremba@...el.com> Date: Mon, 22 May 2023 17:03:54 +0200 > On Fri, May 19, 2023 at 06:46:31PM +0200, Alexander Lobakin wrote: >> From: Larysa Zaremba <larysa.zaremba@...el.com> >> Date: Fri, 12 May 2023 17:25:53 +0200 [...] >>> + nic_mdid = (struct ice_32b_rx_flex_desc_nic *)rx_desc; >>> + *dst = le32_to_cpu(nic_mdid->rss_hash); >>> + return true; >> >> You can just return the hash. `hash == 0` means there's no hash, so it >> basically means `false`, while non-zero is `true`. > > Agree about both hash and timestamp. > > Taking this comment and the earlier on into account, I'll name functions like > that: > > ice_get_rx_hash() > ice_get_vlan_tag() > ice_ptp_get_rx_hwts_ns() Sounds good to me! [...] Thanks, Olek
Powered by blists - more mailing lists