lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <aed0bc3b-2d48-2fd9-9587-5910ad68c180@gmail.com> Date: Mon, 22 May 2023 12:03:06 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org Subject: Re: [PATCH net-next] net: phy: avoid kernel warning dump when stopping an errored PHY On 5/22/23 08:58, Russell King (Oracle) wrote: > When taking a network interface down (or removing a SFP module) after > the PHY has encountered an error, phy_stop() complains incorrectly > that it was called from HALTED state. > > The reason this is incorrect is that the network driver will have > called phy_start() when the interface was brought up, and the fact > that the PHY has a problem bears no relationship to the administrative > state of the interface. Taking the interface administratively down > (which calls phy_stop()) is always the right thing to do after a > successful phy_start() call, whether or not the PHY has encountered > an error. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk> Acked-by: Florian Fainelli <f.fainelli@...il.com> I would argue that the entire phy_error() needs a revamp, yes it's important to know if we have an error "talking" to the PHY, but there is no much that is being actionable in other situations than pluggable SFP modules. -- Florian
Powered by blists - more mailing lists