lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CANEJEGuzoBa_yYHRCa0KygUe=AOhUkSg4u6gWx+QNCuGtKod2Q@mail.gmail.com> Date: Mon, 22 May 2023 13:16:12 -0700 From: Grant Grundler <grundler@...omium.org> To: Pavan Chebbi <pavan.chebbi@...adcom.com> Cc: Ying Hsu <yinghsu@...omium.org>, netdev@...r.kernel.org, grundler@...omium.org, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Paolo Abeni <pabeni@...hat.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, intel-wired-lan@...ts.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] igb: Fix igb_down hung on surprise removal On Thu, May 18, 2023 at 3:36 AM Pavan Chebbi <pavan.chebbi@...adcom.com> wrote: > > On Thu, May 18, 2023 at 12:58 PM Ying Hsu <yinghsu@...omium.org> wrote: > > > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c > > index 58872a4c2540..a8b217368ca1 100644 > > --- a/drivers/net/ethernet/intel/igb/igb_main.c > > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > > @@ -9581,6 +9581,11 @@ static pci_ers_result_t igb_io_error_detected(struct pci_dev *pdev, > > struct net_device *netdev = pci_get_drvdata(pdev); > > struct igb_adapter *adapter = netdev_priv(netdev); > > > > + if (state == pci_channel_io_normal) { > > + dev_warn(&pdev->dev, "Non-correctable non-fatal error reported.\n"); > > + return PCI_ERS_RESULT_CAN_RECOVER; > > + } > > + > > This code may be good to have. But not sure if this should be the fix > for igb_down() synchronization. I have the same opinion. This appears to solve the problem - but I don't know if there is a better way to solve this problem. > Intel guys may comment. Ping? Can we please get feedback from IGB/IGC maintainers this week? (I hope igc maintainers can confirm this isn't an issue for igc.) cheers, grant > > > netif_device_detach(netdev); > > > > if (state == pci_channel_io_perm_failure) > > -- > > 2.40.1.606.ga4b1b128d6-goog > > > >
Powered by blists - more mailing lists