[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230522-profanity-bacon-6058996b62a5-mkl@pengutronix.de>
Date: Mon, 22 May 2023 10:23:23 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: git@...kiesoft.de
Cc: Appana Durga Kedareswara rao <appana.durga.rao@...inx.com>,
Naga Sureshkumar Relli <naga.sureshkumar.relli@...inx.com>,
linux-can@...r.kernel.org, netdev@...r.kernel.org,
Marcel Hellwig <mhellwig@...-group.com>
Subject: Re: [PATCH] can: dev: add transceiver capabilities to xilinx_can
On 22.05.2023 10:00:32, Marc Kleine-Budde wrote:
> On 22.05.2023 09:24:17, git@...kiesoft.de wrote:
> > Hey everyone,
> >
> > is there anything I can do to get this merged?
> > Is there anything missing?
>
> Looks good, while applying I'v moved the phy_power_off() after the
> pm_runtime_put() to make it symmetric with respect to xcan_open().
Also fixed that warning:
| drivers/net/can/xilinx_can.c:220: warning: Function parameter or member 'transceiver' not described in 'xcan_priv'
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists