netdev - Re: [PATCH net-next] nfp: add L4 RSS hashing on UDP traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 May 2023 12:49:06 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Louis Peens <louis.peens@...igine.com>, David Miller
 <davem@...emloft.net>,  Jakub Kicinski <kuba@...nel.org>
Cc: Simon Horman <simon.horman@...igine.com>, netdev@...r.kernel.org, 
	oss-drivers@...igine.com
Subject: Re: [PATCH net-next] nfp: add L4 RSS hashing on UDP traffic

On Mon, 2023-05-22 at 16:13 +0200, Louis Peens wrote:
> From: Jaco Coetzee <jaco.coetzee@...igine.com>
> 
> Add layer 4 RSS hashing on UDP traffic to allow for the
> utilization of multiple queues for multiple connections on
> the same IP address.
> 
> Previously, since the introduction of the driver, RSS hashing
> was only performed on the source and destination IP addresses
> of UDP packets thereby limiting UDP traffic to a single queue
> for multiple connections on the same IP address. The transport
> layer is now included in RSS hashing for UDP traffic, which
> was not previously the case. The reason behind the previous
> limitation is unclear - either a historic limitation of the
> NFP device, or an oversight.

FTR including the transport header in RSS hash for UDP will damage
fragmented traffic, but whoever is relaying on fragments nowadays
should have already at least a dedicated setup.

So patch LGTM,

thanks,

Paolo