netdev - Re: [PATCH net-next] net: Return user_mss for TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJmsM1YH01MsuDovn2LAKTQopOBjg6LNP8Uy_jOJh1+5Q@mail.gmail.com>
Date: Tue, 23 May 2023 13:52:31 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Cambda Zhu <cambda@...ux.alibaba.com>, netdev@...r.kernel.org, 
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Dust Li <dust.li@...ux.alibaba.com>, 
	Tony Lu <tonylu@...ux.alibaba.com>, Jack Yang <mingliang@...ux.alibaba.com>
Subject: Re: [PATCH net-next] net: Return user_mss for TCP_MAXSEG in
 CLOSE/LISTEN state

On Tue, May 23, 2023 at 12:28 PM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On Fri, 2023-05-19 at 16:01 +0800, Cambda Zhu wrote:
> > > This patch removes the tp->mss_cache check in getting TCP_MAXSEG of
> > > CLOSE/LISTEN sock. Checking if tp->mss_cache is zero is probably a bug,
> > > since tp->mss_cache is initialized with TCP_MSS_DEFAULT. Getting
> > > TCP_MAXSEG of sock in other state will still return tp->mss_cache.
> > >
> > > Signed-off-by: Cambda Zhu <cambda@...ux.alibaba.com>
> > > Reported-by: Jack Yang <mingliang@...ux.alibaba.com>
>
> It's a bit strange not seeing Eric being mentioned above:
>

...

Usual way of dealing with this would be to add

Suggested-by: Eric Dumazet <edumazet@...gle.com>
Link: https://lore.kernel.org/netdev/CANn89i+3kL9pYtkxkwxwNMzvC_w3LNUum_2=3u+UyLBmGmifHA@mail.gmail.com/#t


> https://lore.kernel.org/netdev/CANn89i+3kL9pYtkxkwxwNMzvC_w3LNUum_2=3u+UyLBmGmifHA@mail.gmail.com/#t
>
> Paolo
>

Patch SGTM, thanks.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>