netdev - Re: [PATCH net-next 2/3] raw: Stop using RTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4927162d-1766-c495-4be2-873fa280218f@kernel.org>
Date: Tue, 23 May 2023 09:13:35 -0600
From: David Ahern <dsahern@...nel.org>
To: Guillaume Nault <gnault@...hat.com>, David Miller <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>
Cc: netdev@...r.kernel.org, Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net-next 2/3] raw: Stop using RTO_ONLINK.

On 5/22/23 8:38 AM, Guillaume Nault wrote:
> Use ip_sendmsg_scope() to properly initialise the scope in
> flowi4_init_output(), instead of overriding tos with the RTO_ONLINK
> flag. The objective is to eventually remove RTO_ONLINK, which will
> allow converting .flowi4_tos to dscp_t.
> 
> The MSG_DONTROUTE and SOCK_LOCALROUTE cases were already handled by
> raw_sendmsg() (SOCK_LOCALROUTE was handled by the RT_CONN_FLAGS*()
> macros called by get_rtconn_flags()). However, opt.is_strictroute
> wasn't taken into account. Therefore, a side effect of this patch is to
> now honour opt.is_strictroute, and thus align raw_sendmsg() with
> ping_v4_sendmsg() and udp_sendmsg().
> 
> Since raw_sendmsg() was the only user of get_rtconn_flags(), we can now
> remove this function.
> 
> Signed-off-by: Guillaume Nault <gnault@...hat.com>
> ---
>  include/net/ip.h |  5 -----
>  net/ipv4/raw.c   | 10 ++++------
>  2 files changed, 4 insertions(+), 11 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>