netdev - [PATCH net-next v2 0/3] net: tcp: make txhash use consistent for IPv4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230523161453.196094-1-atenart@kernel.org>
Date: Tue, 23 May 2023 18:14:50 +0200
From: Antoine Tenart <atenart@...nel.org>
To: davem@...emloft.net,
	kuba@...nel.org,
	pabeni@...hat.com,
	edumazet@...gle.com
Cc: Antoine Tenart <atenart@...nel.org>,
	netdev@...r.kernel.org,
	i.maximets@....org,
	dceara@...hat.com
Subject: [PATCH net-next v2 0/3] net: tcp: make txhash use consistent for IPv4

Hello,

Series is divided in two parts. First two commits make the txhash (used
for the skb hash in TCP) to be consistent for all IPv4/TCP packets (IPv6
doesn't have the same issue). Last commit improve a hash-related doc.

One example is when using OvS with dp_hash, which uses skb->hash, to
select a path. We'd like packets from the same flow to be consistent, as
well as the hash being stable over time when using net.core.txrehash=0.
Same applies for kernel ECMP which also can use skb->hash.

Thanks!
Antoine

Since v1:
- Rebased on top of latest net-next (one minor conflict).
- Dropped patch 4/4 ("net: skbuff: fix l4_hash comment") as we didn't
  come to an agreement, thread for reference:
  https://lore.kernel.org/all/20230511093456.672221-5-atenart@kernel.org/

Antoine Tenart (3):
  net: tcp: make the txhash available in TIME_WAIT sockets for IPv4 too
  net: ipv4: use consistent txhash in TIME_WAIT and SYN_RECV
  Documentation: net: net.core.txrehash is not specific to listening
    sockets

 Documentation/admin-guide/sysctl/net.rst |  4 ++--
 include/net/ip.h                         |  2 +-
 net/ipv4/ip_output.c                     |  4 +++-
 net/ipv4/tcp_ipv4.c                      | 14 +++++++++-----
 net/ipv4/tcp_minisocks.c                 |  2 +-
 5 files changed, 16 insertions(+), 10 deletions(-)

-- 
2.40.1