netdev - Re: [PATCH net-next] net: Return user_mss for TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1CAC04AB-977F-46FB-81D0-70F90456CC4F@linux.alibaba.com>
Date: Wed, 24 May 2023 09:04:44 +0800
From: Cambda Zhu <cambda@...ux.alibaba.com>
To: Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>
Cc: netdev@...r.kernel.org,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
 Dust Li <dust.li@...ux.alibaba.com>,
 Tony Lu <tonylu@...ux.alibaba.com>,
 Jack Yang <mingliang@...ux.alibaba.com>
Subject: Re: [PATCH net-next] net: Return user_mss for TCP_MAXSEG in
 CLOSE/LISTEN state


> On May 23, 2023, at 21:45, Paolo Abeni <pabeni@...hat.com> wrote:
> 
> On Fri, 2023-05-19 at 16:01 +0800, Cambda Zhu wrote:
>> This patch removes the tp->mss_cache check in getting TCP_MAXSEG of
>> CLOSE/LISTEN sock. Checking if tp->mss_cache is zero is probably a bug,
>> since tp->mss_cache is initialized with TCP_MSS_DEFAULT. Getting
>> TCP_MAXSEG of sock in other state will still return tp->mss_cache.
>> 
>> Signed-off-by: Cambda Zhu <cambda@...ux.alibaba.com>
>> Reported-by: Jack Yang <mingliang@...ux.alibaba.com>
> 
> Could you please re-submit including the Eric's tags?
> 
> Thanks!
> 
> Paolo

Sorry for no Eric's tag. I don't know the 'Suggested-by' tag before,
and I'll re-submit the patch.

Should I add Eric's 'Reviewed-by' to the patch? Or this should be added
by maintainer? Sorry for my ignorance again. :)

Thanks,
Cambda