netdev - Re: [PATCH net-next 4/5] ice: Remove LAG+SRIOV mutual exclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZG3+Jrok46tEjXLV@nanopsycho>
Date: Wed, 24 May 2023 14:08:06 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Dave Ertman <david.m.ertman@...el.com>, mschmidt@...hat.com,
	ihuguet@...hat.com,
	Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	Wojciech Drewek <wojciech.drewek@...el.com>,
	Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next 4/5] ice: Remove LAG+SRIOV mutual exclusion

Wed, May 17, 2023 at 06:55:29PM CEST, anthony.l.nguyen@...el.com wrote:
>From: Dave Ertman <david.m.ertman@...el.com>
>
>There was a change previously to stop SR-IOV and LAG from existing on the
>same interface.  This was to prevent the violation of LACP (Link
>Aggregation Control Protocol).  The method to achieve this was to add a
>no-op Rx handler onto the netdev when SR-IOV VFs were present, thus

Uff, that is a very ugly misuse of rxhandler :/

Glad to see it go!

Reviewed-by: Jiri Pirko <jiri@...dia.com>