netdev - Re: [PATCH net-next] nfc: Switch i2c drivers back to use .probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 24 May 2023 14:44:14 +0200
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: Jean Delvare <jdelvare@...e.de>
Cc: Corey Minyard <cminyard@...sta.com>,
	Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
	Peter Senna Tschudin <peter.senna@...il.com>,
	Sebastian Reichel <sebastian.reichel@...labora.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Jeremy Kerr <jk@...econstruct.com.au>,
	Marek Behún <kabel@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Javier Martinez Canillas <javierm@...hat.com>,
	Adrien Grassein <adrien.grassein@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Kang Chen <void0red@...il.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Petr Machata <petrm@...dia.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Shang XiaoJing <shangxiaojing@...wei.com>,
	Michael Walle <michael@...le.cc>, kernel@...gutronix.de,
	netdev@...r.kernel.org, Hans Verkuil <hverkuil-cisco@...all.nl>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next] nfc: Switch i2c drivers back to use .probe()

Hello Jean,

On Wed, May 24, 2023 at 01:10:11PM +0200, Jean Delvare wrote:
> On Sat, 20 May 2023 19:21:04 +0200, Uwe Kleine-König wrote:
> > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> > call-back type"), all drivers being converted to .probe_new() and then
> > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> > convert back to (the new) .probe() to be able to eventually drop
> > .probe_new() from struct i2c_driver.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > ---
> > Hello,
> > 
> > this patch was generated using coccinelle, but I aligned the result to
> > the per-file indention.
> > 
> > This is one patch for the whole iio subsystem. if you want it split per
> 
> s/iio/nfc/

Yeah, copy&paste failure. I noticed after sending out the patch, but as
it's only in a part of the mail that doesn't make it into git I didn't
care to point it out.

> > driver for improved patch count numbers, please tell me.
> > 
> > This currently fits on top of 6.4-rc1 and next/master. If you apply it
> > somewhere else and get conflicts, feel free to just drop the files with
> > conflicts from this patch and apply anyhow. I'll care about the fallout
> > later then.
> > 
> > Best regards
> > Uwe
> > 
> >  drivers/nfc/fdp/i2c.c       | 2 +-
> >  drivers/nfc/microread/i2c.c | 2 +-
> >  drivers/nfc/nfcmrvl/i2c.c   | 2 +-
> >  drivers/nfc/nxp-nci/i2c.c   | 2 +-
> >  drivers/nfc/pn533/i2c.c     | 2 +-
> >  drivers/nfc/pn544/i2c.c     | 2 +-
> >  drivers/nfc/s3fwrn5/i2c.c   | 2 +-
> >  drivers/nfc/st-nci/i2c.c    | 2 +-
> >  drivers/nfc/st21nfca/i2c.c  | 2 +-
> >  9 files changed, 9 insertions(+), 9 deletions(-)
> > (...)
> 
> Reviewed-by: Jean Delvare <jdelvare@...e.de>

Thanks, but note that davem already applied the patch, so your tag
probably won't make it in.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)