netdev - Re: [patch net-next 00/15] devlink: move port ops into separate structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a5xt4ye5.fsf@nvidia.com>
Date: Wed, 24 May 2023 16:02:48 +0200
From: Petr Machata <petrm@...dia.com>
To: Jiri Pirko <jiri@...nulli.us>
CC: <netdev@...r.kernel.org>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <leon@...nel.org>,
	<saeedm@...dia.com>, <moshe@...dia.com>, <jesse.brandeburg@...el.com>,
	<anthony.l.nguyen@...el.com>, <tariqt@...dia.com>, <idosch@...dia.com>,
	<petrm@...dia.com>, <simon.horman@...igine.com>, <ecree.xilinx@...il.com>,
	<habetsm.xilinx@...il.com>, <michal.wilczynski@...el.com>,
	<jacob.e.keller@...el.com>
Subject: Re: [patch net-next 00/15] devlink: move port ops into separate
 structure


Jiri Pirko <jiri@...nulli.us> writes:

> From: Jiri Pirko <jiri@...dia.com>
>
> In devlink, some of the objects have separate ops registered alongside
> with the object itself. Port however have ops in devlink_ops structure.
> For drivers what register multiple kinds of ports with different ops
> this is not convenient.
>
> This patchset changes does following changes:
> 1) Introduces devlink_port_ops with functions that allow devlink port
>    to be registered passing a pointer to driver port ops. (patch #1)
> 2) Converts drivers to define port_ops and register ports passing the
>    ops pointer. (patches #2, #3, #4, #6, #8, and #9)
> 3) Moves ops from devlink_ops struct to devlink_port_ops.
>    (patches #5, #7, #10-15)
>
> No functional changes.

The mlxsw bits look good to me. Will take this for a spin in our
regression and report back tomorrow.