netdev - Re: [RFC PATCH 1/2] net: Add sysfs files for threaded NAPI.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 May 2023 17:52:16 +0200
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
	Jakub Kicinski <kuba@...nel.org>,
	Kurt Kanzenbach <kurt.kanzenbach@...utronix.de>,
	Paolo Abeni <pabeni@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC PATCH 1/2] net: Add sysfs files for threaded NAPI.

On 2023-05-24 16:41:19 [+0200], Jiri Pirko wrote:
> >How is interface rename handled ?
> 
> Well, having name of interface in sysfs dir/file name is silly, even if
> it would be handled correctly. Should not be there.

The name is there due to the fact that the driver is using it as the
IRQ-name and that is what I recycled here. So it matches what is seen at
the time in proc/interrupts.
Given that it relies on the IRQ-number we may just avoid using the
interrupt name for the folder and simply stick with the napi_id scheme.
The IRQ number should give information for proper mapping.

By providing an explicit name for the napi instance like TxRx-0 (without
the device name) we would have a stable name for a given configuration.
The napi_id while mostly stable is generated on the fly and depends on
device registration order.

Sebastian