netdev - Re: [PATCH net-next v6 1/8] net: wangxun: libwx add tx offload functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 May 2023 21:06:59 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mengyuan Lou <mengyuanlou@...-swift.com>
Cc: netdev@...r.kernel.org, jiawenwu@...stnetic.com
Subject: Re: [PATCH net-next v6 1/8] net: wangxun: libwx add tx offload
 functions

On Tue, 23 May 2023 11:06:51 +0800 Mengyuan Lou wrote:
> +	if (skb->encapsulation) {
> +		union network_header hdr;
> +
> +		switch (first->protocol) {
> +		case htons(ETH_P_IP):
> +			tun_prot = ip_hdr(skb)->protocol;
> +			if (ip_is_fragment(ip_hdr(skb)))
> +				return WX_PTYPE_PKT_IP | WX_PTYPE_TYP_IPFRAG;
> +			ptype = WX_PTYPE_TUN_IPV4;
> +			break;
> +		case htons(ETH_P_IPV6):
> +			wx_get_ipv6_proto(skb, skb_network_offset(skb), &tun_prot);
> +			if (tun_prot == NEXTHDR_FRAGMENT)
> +				return WX_PTYPE_PKT_IP | WX_PTYPE_PKT_IPV6 |
> +				       WX_PTYPE_TYP_IPFRAG;
> +			ptype = WX_PTYPE_TUN_IPV6;

Why does the HW care about fragmented packets?
AFAIU fragmented packets won't have any offloads enabled.