netdev - Re: [PATCH] wifi: mt7601u: update firmware path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 24 May 2023 10:47:21 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Jakub Kicinski <kuba@...nel.org>,  "David S. Miller" <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>,  Paolo Abeni <pabeni@...hat.com>,  Matthias Brugger <matthias.bgg@...il.com>,  AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,  linux-wireless@...r.kernel.org,  netdev@...r.kernel.org,  linux-kernel@...r.kernel.org,  linux-arm-kernel@...ts.infradead.org,  linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] wifi: mt7601u: update firmware path

Kalle Valo <kvalo@...nel.org> writes:

> Daniel Golle <daniel@...rotopia.org> writes:
>
>> mt7601u.bin was moved to mediatek/ folder in linux-wireless via commit
>> 8451c2b1 ("mt76xx: Move the old Mediatek WiFi firmware to mediatek")
>> and linux-firmware release 20230515.
>
> Why was it moved?

Here's the link to the commit in linux-firmware:

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=8451c2b1d529dc1a49328ac9235d3cf5bb8a8fcb

It would be good to include that in the commit log. Unfortunately the
linux-firmware commit doesn't explain why the change is made, oh well.

>> --- a/drivers/net/wireless/mediatek/mt7601u/usb.h
>> +++ b/drivers/net/wireless/mediatek/mt7601u/usb.h
>> @@ -8,7 +8,7 @@
>>  
>>  #include "mt7601u.h"
>>  
>> -#define MT7601U_FIRMWARE	"mt7601u.bin"
>> +#define MT7601U_FIRMWARE	"mediatek/mt7601u.bin"
>
> How do we handle backwards compatibility? We have a rule that old
> userspace needs to work with new kernel and this change breaks that.

Luckily the linux-firmware commit added symlinks so that won't break the
backward compatibility. But I think in the driver we still need to
support both the old and new location for several years. So the driver
should first try the new location, next the old location and only after
that fail.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches