netdev - Re: [PATCH bpf-next 05/21] xsk: add support for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 May 2023 12:28:31 +0200
From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To: Simon Horman <simon.horman@...igine.com>
CC: <bpf@...r.kernel.org>, <ast@...nel.org>, <daniel@...earbox.net>,
	<andrii@...nel.org>, <netdev@...r.kernel.org>, <magnus.karlsson@...el.com>,
	<tirthendu.sarkar@...el.com>, <bjorn@...nel.org>
Subject: Re: [PATCH bpf-next 05/21] xsk: add support for AF_XDP multi-buffer
 on Rx path

On Fri, May 19, 2023 at 11:42:55AM +0200, Simon Horman wrote:
> On Thu, May 18, 2023 at 08:05:29PM +0200, Maciej Fijalkowski wrote:
> > From: Tirthendu Sarkar <tirthendu.sarkar@...el.com>
> > 
> > Add multi-buffer support for AF_XDP by extending the XDP multi-buffer
> > support to be reflected in user-space when a packet is redirected to
> > an AF_XDP socket.
> > 
> > In the XDP implementation, the NIC driver builds the xdp_buff from the
> > first frag of the packet and adds any subsequent frags in the skb_shinfo
> > area of the xdp_buff. In AF_XDP core, XDP buffers are allocated from
> > xdp_sock's pool and data is copied from the driver's xdp_buff and frags.
> > 
> > Once an allocated XDP buffer is full and there is still data to be
> > copied, the 'XDP_PKT_CONTD' flag in'options' field of the corresponding
> > xdp ring decriptor is set and passed to the application. When application
> 
> nit: checkpatch.pl --codespell says:
> 
> :291: WARNING: 'decriptor' may be misspelled - perhaps 'descriptor'?
> xdp ring decriptor is set and passed to the application. When application
>          ^^^^^^^^^

Thanks Simon we will run --codespell against the rest of the patches as
well:)

> 
> ...