netdev - Re: [PATCH] xen/netback: Pass (void *) to virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbUrEZ1FAqMCq35z+g3NF1gx_9c_0vhQw6ioqkyOwaAnw@mail.gmail.com>
Date: Thu, 25 May 2023 15:47:27 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Wei Liu <wei.liu@...nel.org>, Paul Durrant <paul@....org>, xen-devel@...ts.xenproject.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH] xen/netback: Pass (void *) to virt_to_page()

On Thu, May 25, 2023 at 7:12 AM Jakub Kicinski <kuba@...nel.org> wrote:
> On Wed, 24 May 2023 22:11:47 -0700 Jakub Kicinski wrote:
> > On Tue, 23 May 2023 16:03:42 +0200 Linus Walleij wrote:
> > > virt_to_page() takes a virtual address as argument but
> > > the driver passes an unsigned long, which works because
> > > the target platform(s) uses polymorphic macros to calculate
> > > the page.
> > >
> > > Since many architectures implement virt_to_pfn() as
> > > a macro, this function becomes polymorphic and accepts both a
> > > (unsigned long) and a (void *).
> > >
> > > Fix this up by an explicit (void *) cast.
> >
> > Paul, Wei, looks like netdev may be the usual path for this patch
> > to flow thru, although I'm never 100% sure with Xen.
> > Please ack or LUK if you prefer to direct the patch elsewhere?
>
> Ugh, Wei already acked this, sorry for the noise.

Don't worry about it Jakub, it's queued in the asm-generic tree
along with patches making things give nasty compile messages
if they are not typed right, we try to keep down the level of noise
this way: silence it while fixing the root cause.

If you prefer to take it into the net tree that works too but no need.

Yours,
Linus Walleij