lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230525082703.0922dab0@kernel.org> Date: Thu, 25 May 2023 08:27:03 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Jiri Pirko <jiri@...nulli.us> Cc: netdev@...r.kernel.org, pabeni@...hat.com, davem@...emloft.net, edumazet@...gle.com, leon@...nel.org, saeedm@...dia.com, moshe@...dia.com, jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com, tariqt@...dia.com, idosch@...dia.com, petrm@...dia.com, simon.horman@...igine.com, ecree.xilinx@...il.com, habetsm.xilinx@...il.com, michal.wilczynski@...el.com, jacob.e.keller@...el.com Subject: Re: [patch net-next 05/15] devlink: move port_split/unsplit() ops into devlink_port_ops On Thu, 25 May 2023 08:05:22 +0200 Jiri Pirko wrote: > >I think it's because every time I look at struct net_device_ops > >a little part of me gives up. > > Does this work? I checked the existing layout of devlink_ops and the > internal comments are ignored by kdoc. Actually the whole devlink_ops > struct is omitted in kdoc. See: > $ scripts/kernel-doc include/net/devlink.h Hm, it should work, it's documented as a legal way to kdoc: https://www.kernel.org/doc/html/next/doc-guide/kernel-doc.html#in-line-member-documentation-comments We should ask Jon if you're sure it's broken.
Powered by blists - more mailing lists