lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20230525194255.4516-1-forst@pen.gy> Date: Thu, 25 May 2023 21:42:54 +0200 From: Foster Snowhill <forst@....gy> To: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com> Cc: Georgi Valkov <gvalkov@...il.com>, Simon Horman <simon.horman@...igine.com>, linux-usb@...r.kernel.org, netdev@...r.kernel.org Subject: [PATCH net-next v2 1/2] usbnet: ipheth: fix risk of NULL pointer deallocation From: Georgi Valkov <gvalkov@...il.com> The cleanup precedure in ipheth_probe will attempt to free a NULL pointer in dev->ctrl_buf if the memory allocation for this buffer is not successful. Rearrange the goto labels to avoid this risk. Signed-off-by: Georgi Valkov <gvalkov@...il.com> --- drivers/net/usb/ipheth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/ipheth.c b/drivers/net/usb/ipheth.c index 6a769df0b..8875a3d0e 100644 --- a/drivers/net/usb/ipheth.c +++ b/drivers/net/usb/ipheth.c @@ -510,8 +510,8 @@ static int ipheth_probe(struct usb_interface *intf, ipheth_free_urbs(dev); err_alloc_urbs: err_get_macaddr: -err_alloc_ctrl_buf: kfree(dev->ctrl_buf); +err_alloc_ctrl_buf: err_endpoints: free_netdev(netdev); return retval; -- 2.40.1
Powered by blists - more mailing lists