netdev - Re: [PATCH net] amd-xgbe: fix the false linkup in xgbe_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 25 May 2023 10:40:02 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Raju Rangoju <Raju.Rangoju@....com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, Shyam-sundar.S-k@....com,
	Sudheesh Mavila <sudheesh.mavila@....com>
Subject: Re: [PATCH net] amd-xgbe: fix the false linkup in xgbe_phy_status

On Wed, May 24, 2023 at 11:19:02PM +0530, Raju Rangoju wrote:
> In the event of a change in XGBE mode, the current auto-negotiation
> needs to be reset and the AN cycle needs to be re-triggerred. However,
> the current code ignores the return value of xgbe_set_mode(), leading to
> false information as the link is declared without checking the status
> register.
> 
> Fix this by propogating the mode switch status information to

nit: s/propogating/propagating/

     It's probably not worth respinning this patch just to fix spelling.
     But please do consider running checkpatch --codespell

> xgbe_phy_status().
> 
> Fixes: e57f7a3feaef ("amd-xgbe: Prepare for working with more than one type of phy")
> Co-developed-by: Sudheesh Mavila <sudheesh.mavila@....com>
> Signed-off-by: Sudheesh Mavila <sudheesh.mavila@....com>
> Signed-off-by: Raju Rangoju <Raju.Rangoju@....com>

The above nit notwithstanding,

Reviewed-by: Simon Horman <simon.horman@...igine.com>