netdev - Re: [PATCH v2 net] net: mellanox: mlxbf_gige: Fix skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZG8fWujTDjxRXZKn@corigine.com>
Date: Thu, 25 May 2023 10:42:02 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Thomas Bogendoerfer <tbogendoerfer@...e.de>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Asmaa Mnebhi <asmaa@...dia.com>, Liming Sun <limings@...dia.com>,
	David Thompson <davthompson@...dia.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] net: mellanox: mlxbf_gige: Fix skb_panic splat
 under memory pressure

On Wed, May 24, 2023 at 09:49:08PM +0200, Thomas Bogendoerfer wrote:
> Do skb_put() after a new skb has been successfully allocated otherwise
> the reused skb leads to skb_panics or incorrect packet sizes.
> 
> Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de>

Reviewed-by: Simon Horman <simon.horman@...igine.com>