netdev - Re: [PATCH net] tls: improve lockless access safety of tls_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZHB10INz2OEy7v7D@corigine.com>
Date: Fri, 26 May 2023 11:03:12 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, borisp@...dia.com, john.fastabend@...il.com
Subject: Re: [PATCH net] tls: improve lockless access safety of
 tls_err_abort()

On Wed, May 24, 2023 at 10:17:41PM -0700, Jakub Kicinski wrote:
> Most protos' poll() methods insert a memory barrier between
> writes to sk_err and sk_error_report(). This dates back to
> commit a4d258036ed9 ("tcp: Fix race in tcp_poll").
> 
> I guess we should do the same thing in TLS, tcp_poll() does
> not hold the socket lock.
> 
> Fixes: 3c4d7559159b ("tls: kernel TLS support")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <simon.horman@...igine.com>