lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230526095537.yaa3dgn56rwioxcv@skbuf> Date: Fri, 26 May 2023 12:55:37 +0300 From: Vladimir Oltean <olteanv@...il.com> To: Oleksij Rempel <o.rempel@...gutronix.de> Cc: "David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>, Eric Dumazet <edumazet@...gle.com>, Florian Fainelli <f.fainelli@...il.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Woojung Huh <woojung.huh@...rochip.com>, Arun Ramadoss <arun.ramadoss@...rochip.com>, kernel@...gutronix.de, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com, "Russell King (Oracle)" <linux@...linux.org.uk> Subject: Re: [PATCH net-next v2 3/5] net: dsa: microchip: remove ksz_port:on variable On Fri, May 26, 2023 at 09:34:43AM +0200, Oleksij Rempel wrote: > The only place where this variable would be set to false is the > ksz8_config_cpu_port() function. But it is done in a bogus way: > > for (i = 0; i < dev->phy_port_cnt; i++) { > if (i == dev->phy_port_cnt) <--- will be never executed. > break; > p->on = 1; > > So, we never have a situation where p->on = 0. In this case, we can just > remove it. > > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de> > Reviewed-by: Andrew Lunn <andrew@...n.ch> > --- Reviewed-by: Vladimir Oltean <olteanv@...il.com>
Powered by blists - more mailing lists