netdev - Re: [PATCH V2,net] net: mana: Fix perf regression: remove rx_cqes, tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230526082819.26ab0a9a@kernel.org>
Date: Fri, 26 May 2023 08:28:19 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Dexuan Cui
 <decui@...rosoft.com>, KY Srinivasan <kys@...rosoft.com>, Paul Rosswurm
 <paulros@...rosoft.com>, "olaf@...fle.de" <olaf@...fle.de>,
 "vkuznets@...hat.com" <vkuznets@...hat.com>, "davem@...emloft.net"
 <davem@...emloft.net>, "wei.liu@...nel.org" <wei.liu@...nel.org>,
 "edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "leon@...nel.org" <leon@...nel.org>, Long Li
 <longli@...rosoft.com>, "ssengar@...ux.microsoft.com"
 <ssengar@...ux.microsoft.com>, "linux-rdma@...r.kernel.org"
 <linux-rdma@...r.kernel.org>, "daniel@...earbox.net"
 <daniel@...earbox.net>, "john.fastabend@...il.com"
 <john.fastabend@...il.com>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
 "ast@...nel.org" <ast@...nel.org>, Ajay Sharma <sharmaajay@...rosoft.com>,
 "hawk@...nel.org" <hawk@...nel.org>, "tglx@...utronix.de"
 <tglx@...utronix.de>, "shradhagupta@...ux.microsoft.com"
 <shradhagupta@...ux.microsoft.com>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "stable@...r.kernel.org"
 <stable@...r.kernel.org>
Subject: Re: [PATCH V2,net] net: mana: Fix perf regression: remove rx_cqes,
 tx_cqes counters

On Fri, 26 May 2023 14:42:07 +0000 Haiyang Zhang wrote:
> > Horatiu's ask for more details was perfectly reasonable.
> > Provide more details to give the distros and users an
> > idea of the order of magnitude of the problem. Example
> > workload and relative perf hit, anything.  
> 
> For example, a workload is iperf with 128 threads, and with RPS enabled.
> We saw perf regression of 25% with the previous patch adding the counters.
> And this patch eliminates the regression. 

Exactly what I was looking for, thanks. Please put that in the commit
message and post v3 (feel free to add the review tags which came in for
v1 in the meantime).