netdev - Re: [PATCH net-next v3] net: ioctl: Use kernel memory on protocol ioctl callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202305260815.aorxPv1T-lkp@intel.com>
Date: Fri, 26 May 2023 09:15:15 +0800
From: kernel test robot <lkp@...el.com>
To: Breno Leitao <leitao@...ian.org>, dsahern@...nel.org,
	willemdebruijn.kernel@...il.com,
	Remi Denis-Courmont <courmisch@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Alexander Aring <alex.aring@...il.com>,
	Stefan Schmidt <stefan@...enfreihafen.org>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Matthieu Baerts <matthieu.baerts@...sares.net>,
	Mat Martineau <martineau@...nel.org>,
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
	Xin Long <lucien.xin@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org, leit@...com,
	axboe@...nel.dk, asml.silence@...il.com,
	linux-kernel@...r.kernel.org, dccp@...r.kernel.org,
	linux-wpan@...r.kernel.org, mptcp@...ts.linux.dev,
	linux-sctp@...r.kernel.org
Subject: Re: [PATCH net-next v3] net: ioctl: Use kernel memory on protocol
 ioctl callbacks

Hi Breno,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Breno-Leitao/net-ioctl-Use-kernel-memory-on-protocol-ioctl-callbacks/20230525-205741
base:   net-next/main
patch link:    https://lore.kernel.org/r/20230525125503.400797-1-leitao%40debian.org
patch subject: [PATCH net-next v3] net: ioctl: Use kernel memory on protocol ioctl callbacks
config: powerpc-allmodconfig
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/dbeb44f8503d11da0219fc6ef8a56c28cfde1511
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Breno-Leitao/net-ioctl-Use-kernel-memory-on-protocol-ioctl-callbacks/20230525-205741
        git checkout dbeb44f8503d11da0219fc6ef8a56c28cfde1511
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash net/phonet/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305260815.aorxPv1T-lkp@intel.com/

All errors (new ones prefixed by >>):

>> net/phonet/af_phonet.c:43:5: error: redefinition of 'phonet_sk_ioctl'
      43 | int phonet_sk_ioctl(struct sock *sk, unsigned int cmd, void __user *arg)
         |     ^~~~~~~~~~~~~~~
   In file included from net/phonet/af_phonet.c:21:
   include/net/phonet/phonet.h:125:19: note: previous definition of 'phonet_sk_ioctl' with type 'int(struct sock *, unsigned int,  void *)'
     125 | static inline int phonet_sk_ioctl(struct sock *sk, unsigned int cmd, void __user *arg)
         |                   ^~~~~~~~~~~~~~~


vim +/phonet_sk_ioctl +43 net/phonet/af_phonet.c

    42	
  > 43	int phonet_sk_ioctl(struct sock *sk, unsigned int cmd, void __user *arg)
    44	{
    45		int karg;
    46	
    47		switch (cmd) {
    48		case SIOCPNADDRESOURCE:
    49		case SIOCPNDELRESOURCE:
    50			if (get_user(karg, (int __user *)arg))
    51				return -EFAULT;
    52	
    53			return sk->sk_prot->ioctl(sk, cmd, &karg);
    54		}
    55		/* A positive return value means that the ioctl was not processed */
    56		return 1;
    57	}
    58	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

View attachment "config" of type "text/plain" (331594 bytes)