netdev - Re: [PATCH net v2] tcp: Return user_mss for TCP_MAXSEG in CLOSE/LISTEN state if user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230526194136.1c9f8d6c@kernel.org>
Date: Fri, 26 May 2023 19:41:36 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Cambda Zhu <cambda@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Jason Xing <kerneljasonxing@...il.com>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>, Dust Li <dust.li@...ux.alibaba.com>, Tony Lu
 <tonylu@...ux.alibaba.com>, Jack Yang <mingliang@...ux.alibaba.com>
Subject: Re: [PATCH net v2] tcp: Return user_mss for TCP_MAXSEG in
 CLOSE/LISTEN state if user_mss set

On Wed, 24 May 2023 21:13:31 +0800 Cambda Zhu wrote:
> This patch replaces the tp->mss_cache check in getting TCP_MAXSEG
> with tp->rx_opt.user_mss check for CLOSE/LISTEN sock. Since
> tp->mss_cache is initialized with TCP_MSS_DEFAULT, checking if
> it's zero is probably a bug.
> 
> With this change, getting TCP_MAXSEG before connecting will return
> default MSS normally, and return user_mss if user_mss is set.

Hi, your patch was marked as "Changes requested" by DaveM (I think).
Presumably because of the missing CCs. Would you mind resending one
more time with the fuller CC list?