[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKH8qBtTDi+0dgrn=OfCDrbVSAKZN0ktcnSddS=sV518R-dx-w@mail.gmail.com>
Date: Fri, 26 May 2023 16:15:10 -0700
From: Stanislav Fomichev <sdf@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
pabeni@...hat.com
Subject: Re: [PATCH net] netlink: specs: correct types of legacy arrays
On Fri, May 26, 2023 at 3:07 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> ethtool has some attrs which dump multiple scalars into
> an attribute. The spec currently expects one attr per entry.
>
> Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
Acked-by: Stanislav Fomichev <sdf@...gle.com>
> ---
> CC: sdf@...gle.com
> ---
> Documentation/netlink/specs/ethtool.yaml | 32 ++++++------------------
> 1 file changed, 8 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 129f413ea349..3abc576ff797 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -60,22 +60,6 @@ doc: Partial family for Ethtool Netlink.
> type: nest
> nested-attributes: bitset-bits
>
> - -
> - name: u64-array
> - attributes:
> - -
> - name: u64
> - type: nest
> - multi-attr: true
> - nested-attributes: u64
> - -
> - name: s32-array
> - attributes:
> - -
> - name: s32
> - type: nest
> - multi-attr: true
> - nested-attributes: s32
> -
> name: string
> attributes:
> @@ -705,16 +689,16 @@ doc: Partial family for Ethtool Netlink.
> type: u8
> -
> name: corrected
> - type: nest
> - nested-attributes: u64-array
> + type: binary
> + sub-type: u64
> -
> name: uncorr
> - type: nest
> - nested-attributes: u64-array
> + type: binary
> + sub-type: u64
> -
> name: corr-bits
> - type: nest
> - nested-attributes: u64-array
> + type: binary
> + sub-type: u64
> -
> name: fec
> attributes:
> @@ -827,8 +811,8 @@ doc: Partial family for Ethtool Netlink.
> type: u32
> -
> name: index
> - type: nest
> - nested-attributes: s32-array
> + type: binary
> + sub-type: s32
> -
> name: module
> attributes:
> --
> 2.40.1
>
Powered by blists - more mailing lists