netdev - Re: [PATCH net-next 2/8] Drop the netfs_ prefix from netfs_extract_iter_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 27 May 2023 14:24:57 +0200
From: Simon Horman <simon.horman@...igine.com>
To: David Howells <dhowells@...hat.com>
Cc: netdev@...r.kernel.org, Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Willem de Bruijn <willemdebruijn.kernel@...il.com>,
	David Ahern <dsahern@...nel.org>,
	Matthew Wilcox <willy@...radead.org>, Jens Axboe <axboe@...nel.dk>,
	linux-crypto@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Jeff Layton <jlayton@...nel.org>,
	Steve French <sfrench@...ba.org>,
	Shyam Prasad N <nspmangalore@...il.com>,
	Rohith Surabattula <rohiths.msft@...il.com>,
	linux-cachefs@...hat.com, linux-cifs@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH net-next 2/8] Drop the netfs_ prefix from
 netfs_extract_iter_to_sg()

On Fri, May 26, 2023 at 03:30:58PM +0100, David Howells wrote:

...

> @@ -1307,7 +1307,7 @@ static ssize_t netfs_extract_xarray_to_sg(struct iov_iter *iter,
>  }
>  
>  /**
> - * netfs_extract_iter_to_sg - Extract pages from an iterator and add ot an sglist
> + * extract_iter_to_sg - Extract pages from an iterator and add ot an sglist

nit: While we are here, perhaps

     s/and add ot an/and add to an/

>   * @iter: The iterator to extract from
>   * @maxsize: The amount of iterator to copy
>   * @sgtable: The scatterlist table to fill in

..