lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230528201407.394235f5@jic23-huawei> Date: Sun, 28 May 2023 20:14:07 +0100 From: Jonathan Cameron <jic23@...nel.org> To: Matti Vaittinen <mazziesaccount@...il.com> Cc: andy.shevchenko@...il.com, Matti Vaittinen <matti.vaittinen@...rohmeurope.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Daniel Scally <djrscally@...il.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Wolfram Sang <wsa@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Andreas Klinger <ak@...klinger.de>, Marcin Wojtas <mw@...ihalf.com>, Russell King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Jonathan Neuschäfer <j.neuschaefer@....net>, Linus Walleij <linus.walleij@...aro.org>, Paul Cercueil <paul@...pouillou.net>, Akhil R <akhilrajeev@...dia.com>, linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org, linux-iio@...r.kernel.org, netdev@...r.kernel.org, openbmc@...ts.ozlabs.org, linux-gpio@...r.kernel.org, linux-mips@...r.kernel.org Subject: Re: [PATCH v5 3/8] net-next: mvpp2: relax return value check for IRQ get On Mon, 22 May 2023 08:15:01 +0300 Matti Vaittinen <mazziesaccount@...il.com> wrote: > Hi Andy, > > On 5/21/23 20:19, andy.shevchenko@...il.com wrote: > > Fri, May 19, 2023 at 02:01:47PM +0300, Matti Vaittinen kirjoitti: > >> fwnode_irq_get[_byname]() were changed to not return 0 anymore. > >> > >> Drop check for return value 0. > > > > ... > > > >> - if (v->irq <= 0) { > >> + if (v->irq < 0) { > >> ret = -EINVAL; > > > > ret = v->irq; > > > > ? > > For me that seems to be correct, yes. This, however, would be a > functional change and in my opinion it should be done separately from > this API change. Ah. I commented on this as well in v6. Roll us that separate patch and I expect we'll both be happy ;) Jonathan > > > > >> goto err; > >> } > > >
Powered by blists - more mailing lists