lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <6474cb52.7b0a0220.ece09.c49e@mx.google.com> Date: Mon, 29 May 2023 17:52:08 +0200 From: Christian Marangi <ansuelsmth@...il.com> To: Andrew Lunn <andrew@...n.ch> Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>, Jonathan Corbet <corbet@....net>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, linux-leds@...r.kernel.org, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [net-next PATCH v3 08/13] leds: trigger: netdev: add support for LED hw control On Mon, May 29, 2023 at 05:45:45PM +0200, Andrew Lunn wrote: > > static bool can_hw_control(struct led_netdev_data *trigger_data) > > { > > + unsigned int interval = atomic_read(&trigger_data->interval); > > struct led_classdev *led_cdev = trigger_data->led_cdev; > > + unsigned long default_interval = msecs_to_jiffies(50); > > nitpick: > > We have 50 in netdev_trig_activate(). Now it is used twice, it would > be nice to replace it with a #define. I doubt it will ever get > changed, but we do want them to be identical. > > Reviewed-by: Andrew Lunn <andrew@...n.ch> > Good idea. I will move the value to a define in v4, guess it's ok to keep the review tag for this simple change? -- Ansuel
Powered by blists - more mailing lists