lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <923b2fdc-6313-67d7-5577-720da309eccf@blackwall.org> Date: Mon, 29 May 2023 17:49:35 +0300 From: Nikolay Aleksandrov <razor@...ckwall.org> To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org, bridge@...ts.linux-foundation.org Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, taras.chornyi@...ision.eu, saeedm@...dia.com, leon@...nel.org, petrm@...dia.com, vladimir.oltean@....com, claudiu.manoil@....com, alexandre.belloni@...tlin.com, UNGLinuxDriver@...rochip.com, jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us, roopa@...dia.com, simon.horman@...igine.com Subject: Re: [PATCH net-next v2 6/8] mlxsw: spectrum_flower: Do not force matching on iif On 29/05/2023 14:48, Ido Schimmel wrote: > Currently, mlxsw only supports the 'ingress_ifindex' field in the > 'FLOW_DISSECTOR_KEY_META' key, but subsequent patches are going to add > support for the 'l2_miss' field as well. It is valid to only match on > 'l2_miss' without 'ingress_ifindex', so do not force matching on it. > > Signed-off-by: Ido Schimmel <idosch@...dia.com> > --- > > Notes: > v2: > * New patch. > > drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c > index 2b0bae847eb9..9c62c12e410b 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c > +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c > @@ -290,6 +290,9 @@ mlxsw_sp_flower_parse_meta_iif(struct mlxsw_sp_acl_rule_info *rulei, > struct mlxsw_sp_port *mlxsw_sp_port; > struct net_device *ingress_dev; > > + if (!match->mask->ingress_ifindex) > + return 0; > + > if (match->mask->ingress_ifindex != 0xFFFFFFFF) { > NL_SET_ERR_MSG_MOD(extack, "Unsupported ingress ifindex mask"); > return -EINVAL; Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>
Powered by blists - more mailing lists