netdev - Re: [net-next PATCH v3 03/13] Documentation: leds: leds-class: Document new Hardware driven LEDs APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f171eaa-86c9-42de-88d9-a0dbc9baeb7f@lunn.ch>
Date: Mon, 29 May 2023 16:52:06 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Bagas Sanjaya <bagasdotme@...il.com>
Cc: Christian Marangi <ansuelsmth@...il.com>, Pavel Machek <pavel@....cz>,
	Lee Jones <lee@...nel.org>, Jonathan Corbet <corbet@....net>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-leds@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [net-next PATCH v3 03/13] Documentation: leds: leds-class:
 Document new Hardware driven LEDs APIs

On Mon, May 29, 2023 at 03:10:15PM +0700, Bagas Sanjaya wrote:
> On Sat, May 27, 2023 at 01:28:44PM +0200, Christian Marangi wrote:
> > +     - hw_control_set:
> > +                activate hw control. LED driver will use the provided
> > +                flags passed from the supported trigger, parse them to
> > +                a set of mode and setup the LED to be driven by hardware
> > +                following the requested modes.
> > +
> > +                Set LED_OFF via the brightness_set to deactivate hw control.
> > +
> > +                Return 0 on success, a negative error number on flags apply
> > +                fail.
> 		   "... on failing to apply flags."
> 
> > +    - hw_control_get_device:
> > +                return the device associated with the LED driver in
> > +                hw control. A trigger might use this to match the
> > +                returned device from this function with a configured
> > +                device for the trigger as the source for blinking
> > +                events and correctly enable hw control.
> > +                (example a netdev trigger configured to blink for a
> > +                particular dev match the returned dev from get_device
> > +                to set hw control)
> > +
> > +                Return a device or NULL if nothing is currently attached.
> Returns a device name?

How about "Returns a pointer to a struct device ..."

    Andrew