lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ab35060f-405d-4aaa-8e84-9f5a77e5eee3@lunn.ch> Date: Mon, 29 May 2023 17:25:45 +0200 From: Andrew Lunn <andrew@...n.ch> To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk> Cc: Heiner Kallweit <hkallweit1@...il.com>, Jiawen Wu <jiawenwu@...stnetic.com>, Maxime Chevallier <maxime.chevallier@...tlin.com>, Simon Horman <simon.horman@...igine.com>, Jose Abreu <Jose.Abreu@...opsys.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org Subject: Re: [PATCH net-next 2/6] net: pcs: xpcs: add xpcs_create_mdiodev() > void xpcs_destroy(struct dw_xpcs *xpcs) > { > + if (xpcs) > + mdio_device_put(xpcs->mdiodev); > kfree(xpcs); > } Nit: Is the if () needed? Can destroy be called if create was not successful? Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists