netdev - Re: [net-next PATCH v3 05/13] leds: trigger: netdev: introduce check for possible hw control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ce434f5-dfa7-4ef5-800f-7bb328ec5070@lunn.ch>
Date: Mon, 29 May 2023 17:32:21 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
	Jonathan Corbet <corbet@....net>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-leds@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [net-next PATCH v3 05/13] leds: trigger: netdev: introduce check
 for possible hw control

On Sat, May 27, 2023 at 01:28:46PM +0200, Christian Marangi wrote:
> Introduce function to check if the requested mode can use hw control in
> preparation for hw control support. Currently everything is handled in
> software so can_hw_control will always return false.
> 
> Add knob with the new value hw_control in trigger_data struct to
> set hw control possible. Useful for future implementation to implement
> in set_baseline_state() the required function to set the requested mode
> using LEDs hw control ops and in other function to reject set if hw
> control is currently active.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew