netdev - Re: [PATCH v3 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1dbf113c-7592-68bd-6aaf-05ff1d8c538c@starfivetech.com>
Date: Mon, 29 May 2023 11:46:19 +0800
From: Guo Samin <samin.guo@...rfivetech.com>
To: Conor Dooley <conor@...nel.org>
CC: <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<netdev@...r.kernel.org>, Peter Geis <pgwipeout@...il.com>, Frank
	<Frank.Sae@...or-comm.com>, "David S . Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Andrew Lunn <andrew@...n.ch>, "Heiner
 Kallweit" <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>,
	Yanhong Wang <yanhong.wang@...rfivetech.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: net: motorcomm: Add pad driver
 strength cfg

Re: [PATCH v3 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg
From: Conor Dooley <conor@...nel.org>
to: Samin Guo <samin.guo@...rfivetech.com>
data: 2023/5/27

> On Fri, May 26, 2023 at 05:05:01PM +0800, Samin Guo wrote:
>> The motorcomm phy (YT8531) supports the ability to adjust the drive
>> strength of the rx_clk/rx_data, the value range of pad driver
>> strength is 0 to 7.
>>
>> Signed-off-by: Samin Guo <samin.guo@...rfivetech.com>
>> ---
>>  .../devicetree/bindings/net/motorcomm,yt8xxx.yaml    | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
>> index 157e3bbcaf6f..29a1997a1577 100644
>> --- a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
>> +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
>> @@ -52,6 +52,18 @@ properties:
>>        for a timer.
>>      type: boolean
>>  
>> +  motorcomm,rx-clk-driver-strength:
>> +    description: drive strength of rx_clk pad.
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ]
> 
> I think you should use minimum & maximum instead of these listed out
> enums.

Thanks Conor, This can be improved in the next version.

 You have also had this comment since v1 & were reminded of it on
> v2 by Krzysztof: "What do the numbers mean? What are the units? mA?"
> 


The good news is that we just got some data about units from Motorcomm. 
Maybe I can post the data show of the unit later after I get the complete data.



> This information should go into the binding, not sit in a thread on a
> mailing list that noone will look at when trying to write a DT :(
> 
> Thanks,
> Conor.
>

Yes，when we have the complete 'unit' data, it will be placed in DT.

Best regards,
Samin
 
>> +    default: 3
>> +
>> +  motorcomm,rx-data-driver-strength:
>> +    description: drive strength of rx_data/rx_ctl rgmii pad.
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ]
>> +    default: 3
>> +
>>    motorcomm,tx-clk-adj-enabled:
>>      description: |
>>        This configuration is mainly to adapt to VF2 with JH7110 SoC.
>> -- 
>> 2.17.1
>>