lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZHXKt2Zfr/zSqIMq@shell.armlinux.org.uk> Date: Tue, 30 May 2023 11:06:47 +0100 From: "Russell King (Oracle)" <linux@...linux.org.uk> To: Dan Carpenter <dan.carpenter@...aro.org> Cc: Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>, Oleksij Rempel <linux@...pel-privat.de>, Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH net] net: phy: fix a signedness bug in genphy_loopback() On Tue, May 30, 2023 at 10:49:22AM +0100, Russell King (Oracle) wrote: > On Tue, May 30, 2023 at 12:23:32PM +0300, Dan Carpenter wrote: > > I don't see an issue in r8169_main.c and in drivers/net/phy/phy_device.c > > then I only find the bug from this patch. > > I agree - inspecting the code reveals that "val" would be of type "int". > > > + BUILD_BUG_ON((typeof(val))~0ULL > 0); \ > > I've just thrown this in to my builds, and building for arm64 using > debian stable's gcc, I don't see any errors with genphy_loopback() > suitably hacked, even with r8169 included in the build. Also successfully built with 32-bit ARM gcc. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists