netdev - Re: [PATCH net-next] net/netlink: fix NETLINK_LIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHXjhNvLCbxrWK01@corigine.com>
Date: Tue, 30 May 2023 13:52:36 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Pedro Tammela <pctammela@...atatu.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, kuniyu@...zon.com,
	dh.herrmann@...il.com, jhs@...atatu.com
Subject: Re: [PATCH net-next] net/netlink: fix NETLINK_LIST_MEMBERSHIPS
 length report

On Mon, May 29, 2023 at 12:33:35PM -0300, Pedro Tammela wrote:
> The current code for the length calculation wrongly truncates the reported
> length of the groups array, causing an under report of the subscribed
> groups. To fix this, use 'BITS_TO_BYTES()' which rounds up the
> division by 8.
> 
> Fixes: b42be38b2778 ("netlink: add API to retrieve all group memberships")
> Signed-off-by: Pedro Tammela <pctammela@...atatu.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>