lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZHXw4/JCPIMShHgH@DEN-LT-70577> Date: Tue, 30 May 2023 12:49:39 +0000 From: Daniel Machon <daniel.machon@...rochip.com> To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk> CC: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Florian Fainelli <f.fainelli@...il.com>, Horatiu Vultur <horatiu.vultur@...rochip.com>, Ioana Ciornei <ioana.ciornei@....com>, "Jakub Kicinski" <kuba@...nel.org>, Lars Povlsen <lars.povlsen@...rochip.com>, <linux-arm-kernel@...ts.infradead.org>, Madalin Bucur <madalin.bucur@....com>, Marcin Wojtas <mw@...ihalf.com>, Michal Simek <michal.simek@....com>, <netdev@...r.kernel.org>, Paolo Abeni <pabeni@...hat.com>, Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>, Sean Anderson <sean.anderson@...o.com>, Steen Hegelund <Steen.Hegelund@...rochip.com>, Taras Chornyi <taras.chornyi@...ision.eu>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, <UNGLinuxDriver@...rochip.com>, Vladimir Oltean <olteanv@...il.com> Subject: Re: [PATCH RFC net-next 9/9] net: sparx5: switch PCS driver to use phylink_pcs_neg_mode() > Use the newly introduced phylink_pcs_neg_mode() to configure whether > inband-AN should be used. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk> > --- > drivers/net/ethernet/microchip/sparx5/sparx5_phylink.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_phylink.c b/drivers/net/ethernet/microchip/sparx5/sparx5_phylink.c > index bb97d27a1da4..87bdec185383 100644 > --- a/drivers/net/ethernet/microchip/sparx5/sparx5_phylink.c > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_phylink.c > @@ -99,13 +99,17 @@ static int sparx5_pcs_config(struct phylink_pcs *pcs, > { > struct sparx5_port *port = sparx5_pcs_to_port(pcs); > struct sparx5_port_config conf; > + unsigned int neg_mode; > int ret = 0; > > + neg_mode = phylink_pcs_neg_mode(mode, interface, advertising); > + > conf = port->conf; > conf.power_down = false; > conf.portmode = interface; > - conf.inband = phylink_autoneg_inband(mode); > - conf.autoneg = phylink_test(advertising, Autoneg); > + conf.inband = neg_mode == PHYLINK_PCS_NEG_INBAND_DISABLED || > + neg_mode == PHYLINK_PCS_NEG_INBAND_ENABLED; > + conf.autoneg = neg_mode == PHYLINK_PCS_NEG_INBAND_ENABLED; > conf.pause_adv = 0; > if (phylink_test(advertising, Pause)) > conf.pause_adv |= ADVERTISE_1000XPAUSE; > -- > 2.30.2 > > Hi Russel, This looks good to me. Tested on sparx5 pcb134 and pcb135. /Daniel
Powered by blists - more mailing lists