lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <851564e1-1e23-4950-8aab-50c7693b4b8d@lunn.ch> Date: Tue, 30 May 2023 15:11:13 +0200 From: Andrew Lunn <andrew@...n.ch> To: Lu Hongfei <luhongfei@...o.com> Cc: Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "open list:ETHERNET PHY LIBRARY" <netdev@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, opensource.kernel@...o.com Subject: Re: [PATCH] net: Replace the ternary conditional operator with min() On Tue, May 30, 2023 at 04:45:30PM +0800, Lu Hongfei wrote: > It would be better to replace the traditional ternary conditional > operator with min() Hi Lu Adding to the comments from Russell and Heiner, if i remember correctly, the exact same change has been rejected before, for the same reasons. When submitting a patch, please do a search first and see if somebody else has already received a reject. Did you use a static analyser to find this? Please submit a patch to the static analyser to stop it reporting code like this. That will save wasting peoples time having to develop such bad patches, and reviewers having to reject them. Andrew
Powered by blists - more mailing lists