lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAL+tcoBvHLxqhwefCws-yXF9qu0dJj4ESt+c=k4nt+ybKJcyuA@mail.gmail.com> Date: Tue, 30 May 2023 23:05:57 +0800 From: Jason Xing <kerneljasonxing@...il.com> To: Eric Dumazet <edumazet@...gle.com> Cc: fuyuanli <fuyuanli@...iglobal.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Neal Cardwell <ncardwell@...gle.com>, ycheng <ycheng@...gle.com>, toke <toke@...e.dk>, netdev@...r.kernel.org, Weiping Zhang <zhangweiping@...iglobal.com>, Tio Zhang <tiozhang@...iglobal.com> Subject: Re: [PATCH net v2] tcp: fix mishandling when the sack compression is deferred On Tue, May 30, 2023 at 10:51 PM Eric Dumazet <edumazet@...gle.com> wrote: > > On Tue, May 30, 2023 at 4:32 PM Jason Xing <kerneljasonxing@...il.com> wrote: > > > > I'm confused. You said in the previous email: > > "As a bonus, no need to send one patch for net, and another in net-next, > > trying to 'fix' issues that should have been fixed cleanly in a single patch." > > > > So we added "introducing ICSK_ACK_TIMER flag for sack compression" to > > fix them on top of the patch you suggested. > > > > I can remove the Suggested-by label. For now, I do care about your > > opinion on the current patch. > > > > Well...should I give up introducing that flag and then leave that > > 'issue' behind? :S > > Please let the fix go alone. Roger that. So I can add back your suggested-by right?! :) > > Then I will look at your patch, but honestly I fail to see the _reason_ for it. > > In case you missed it, tcp_event_ack_sent() calls > inet_csk_clear_xmit_timer(sk, ICSK_TIME_DACK); Thanks, I will take a deep look at this tomorrow since it's too late. Thanks again, Jason
Powered by blists - more mailing lists