lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <d030c097-ac93-eed4-5bdd-11f902b16fca@kernel.org> Date: Tue, 30 May 2023 08:57:54 -0600 From: David Ahern <dsahern@...nel.org> To: Benjamin Poirier <bpoirier@...dia.com>, netdev@...r.kernel.org Cc: Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org, Ido Schimmel <idosch@...dia.com> Subject: Re: [PATCH net-next 1/4] nexthop: Factor out hash threshold fdb nexthop selection On 5/29/23 2:19 PM, Benjamin Poirier wrote: > diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c > index f95142e56da0..27089dea0ed0 100644 > --- a/net/ipv4/nexthop.c > +++ b/net/ipv4/nexthop.c > @@ -1152,11 +1152,31 @@ static bool ipv4_good_nh(const struct fib_nh *nh) > return !!(state & NUD_VALID); > } > > +static struct nexthop *nexthop_select_path_fdb(struct nh_group *nhg, int hash) > +{ > + int i; > + > + for (i = 0; i < nhg->num_nh; i++) { > + struct nh_grp_entry *nhge = &nhg->nh_entries[i]; > + > + if (hash > atomic_read(&nhge->hthr.upper_bound)) > + continue; > + > + return nhge->nh; > + } > + > + WARN_ON_ONCE(1); I do not see how the stack is going to provide useful information; it should always be vxlan_xmit ... nexthop_select_path_fdb, right? besides that: Reviewed-by: David Ahern <dsahern@...nel.org>
Powered by blists - more mailing lists