lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <af880ce8-a7b8-138e-1ab9-8c89e662eecf@gmail.com> Date: Tue, 30 May 2023 10:51:27 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Andrew Lunn <andrew@...n.ch>, netdev <netdev@...r.kernel.org> Cc: Heiner Kallweit <hkallweit1@...il.com>, Russell King <rmk+kernel@...linux.org.uk>, Oleksij Rempel <linux@...pel-privat.de> Subject: Re: [RFC/RFTv3 01/24] net: phy: Add phydev->eee_active to simplify adjust link callbacks On 3/30/23 17:54, Andrew Lunn wrote: > MAC drivers which support EEE need to know the results of the EEE > auto-neg in order to program the hardware to perform EEE or not. The > oddly named phy_init_eee() can be used to determine this, it returns 0 > if EEE should be used, or a negative error code, > e.g. -EOPPROTONOTSUPPORT if the PHY does not support EEE or negotiate > resulted in it not being used. > > However, many MAC drivers get this wrong. Add phydev->eee_active which > indicates the result of the autoneg for EEE, including if EEE is > administratively disabled with ethtool. The MAC driver can then access > this in the same way as link speed and duplex in the adjust link > callback. > > Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk> > Signed-off-by: Andrew Lunn <andrew@...n.ch> Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com> -- Florian
Powered by blists - more mailing lists