lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZHY9AE5swwyX06p0@shell.armlinux.org.uk> Date: Tue, 30 May 2023 19:14:24 +0100 From: "Russell King (Oracle)" <linux@...linux.org.uk> To: Florian Fainelli <f.fainelli@...il.com> Cc: Andrew Lunn <andrew@...n.ch>, netdev <netdev@...r.kernel.org>, Heiner Kallweit <hkallweit1@...il.com>, Oleksij Rempel <linux@...pel-privat.de> Subject: Re: [RFC/RFTv3 04/24] net: phy: Keep track of EEE tx_lpi_enabled On Tue, May 30, 2023 at 11:11:22AM -0700, Florian Fainelli wrote: > On 3/30/23 17:54, Andrew Lunn wrote: > > Have phylib keep track of the EEE tx_lpi_enabled configuration. This > > simplifies the MAC drivers, in that they don't need to store it. > > > > Future patches to phylib will also make use of this information to > > further simplify the MAC drivers. > > > > Signed-off-by: Andrew Lunn <andrew@...n.ch> > > Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com> To Andrew: I'm not sure this is a good idea, having read 802.3 recently. EEE is supported on optical as well, which means that LPI, being a MAC thing, would need to be controlled without the PHY present. A phylink using driver would need to store the LPI config when it's used without a phylib PHY. Maybe phylink can store it on behalf of of the driver instead though. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists