lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZHZVGUJ3ROybmBJj@corigine.com> Date: Tue, 30 May 2023 21:57:13 +0200 From: Simon Horman <simon.horman@...igine.com> To: Maciej Fijalkowski <maciej.fijalkowski@...el.com> Cc: bpf@...r.kernel.org, ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, netdev@...r.kernel.org, magnus.karlsson@...el.com, bjorn@...nel.org, tirthendu.sarkar@...el.com Subject: Re: [PATCH v2 bpf-next 13/22] xsk: report ZC multi-buffer capability via xdp_features On Tue, May 30, 2023 at 02:31:20PM +0200, Maciej Fijalkowski wrote: > On Tue, May 30, 2023 at 01:55:45PM +0200, Simon Horman wrote: > > On Mon, May 29, 2023 at 05:50:15PM +0200, Maciej Fijalkowski wrote: > > > Introduce new xdp_feature NETDEV_XDP_ACT_NDO_ZC_SG that will be used to > > > find out if user space that wants to do ZC multi-buffer will be able to > > > do so against underlying ZC driver. > > > > > > Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com> > > > --- > > > include/uapi/linux/netdev.h | 4 ++-- > > > net/xdp/xsk_buff_pool.c | 6 ++++++ > > > 2 files changed, 8 insertions(+), 2 deletions(-) > > > > > > diff --git a/include/uapi/linux/netdev.h b/include/uapi/linux/netdev.h > > > index 639524b59930..bfca07224f7b 100644 > > > --- a/include/uapi/linux/netdev.h > > > +++ b/include/uapi/linux/netdev.h > > > @@ -33,8 +33,8 @@ enum netdev_xdp_act { > > > NETDEV_XDP_ACT_HW_OFFLOAD = 16, > > > NETDEV_XDP_ACT_RX_SG = 32, > > > NETDEV_XDP_ACT_NDO_XMIT_SG = 64, > > > - > > > - NETDEV_XDP_ACT_MASK = 127, > > > + NETDEV_XDP_ACT_NDO_ZC_SG = 128, > > > > Hi Maciej, > > > > Please consider adding NETDEV_XDP_ACT_NDO_ZC_SG to the Kernel doc > > a just above netdev_xdp_act. > > right, my bad. i'll do this in next rev but i'd like to gather more > feedback from people. thanks once again for spotting an issue. Thanks, good plan.
Powered by blists - more mailing lists