netdev - RE: [PATCH iproute2] vdpa: propagate error from cmd_dev_vstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 30 May 2023 04:05:51 +0000
From: Parav Pandit <parav@...dia.com>
To: Andrea Claudi <aclaudi@...hat.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "stephen@...workplumber.org" <stephen@...workplumber.org>,
	"dsahern@...il.com" <dsahern@...il.com>
Subject: RE: [PATCH iproute2] vdpa: propagate error from cmd_dev_vstats_show()



> From: Andrea Claudi <aclaudi@...hat.com>
> Sent: Monday, May 29, 2023 5:42 PM
> 
> Error potentially returned from mnlu_gen_socket_sndrcv() are propagated for
> each and every invocation in vdpa. Let's do the same here.
> 
> Fixes: 6f97e9c9337b ("vdpa: Add support for reading vdpa device statistics")
> Signed-off-by: Andrea Claudi <aclaudi@...hat.com>
> ---
>  vdpa/vdpa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c
> index 27647d73..8bbe452c 100644
> --- a/vdpa/vdpa.c
> +++ b/vdpa/vdpa.c
> @@ -986,7 +986,7 @@ static int cmd_dev_vstats_show(struct vdpa *vdpa, int
> argc, char **argv)
>  	pr_out_section_start(vdpa, "vstats");
>  	err = mnlu_gen_socket_sndrcv(&vdpa->nlg, nlh,
> cmd_dev_vstats_show_cb, vdpa);
>  	pr_out_section_end(vdpa);
> -	return 0;
> +	return err;
>  }
> 
>  static int cmd_dev_vstats(struct vdpa *vdpa, int argc, char **argv)
> --
> 2.40.1

Reviewed-by: Parav Pandit <parav@...dia.com>