netdev - [PATCH] kernel: bpf: syscall: fix a possible sleep-in-atomic bug in __bpf_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230530045409.440958-1-rkannoth@marvell.com>
Date: Tue, 30 May 2023 10:24:09 +0530
From: Ratheesh Kannoth <rkannoth@...vell.com>
To: <starmiku1207184332@...il.com>, <ast@...nel.org>, <daniel@...earbox.net>,
        <john.fastabend@...il.com>, <andrii@...nel.org>,
        <martin.lau@...ux.dev>, <song@...nel.org>, <yhs@...com>,
        <kpsingh@...nel.org>, <sdf@...gle.com>, <haoluo@...gle.com>,
        <jolsa@...nel.org>, <davem@...emloft.net>, <kuba@...nel.org>,
        <hawk@...nel.org>
CC: <bpf@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: [PATCH] kernel: bpf: syscall: fix a possible sleep-in-atomic bug in __bpf_prog_put()

From: starmiku1207184332@...il.com

>
>+			// safely calling vfree() under any context
do we need this comment as code is self explanatory.

> 			INIT_WORK(&aux->work, bpf_prog_put_deferred);
> 			schedule_work(&aux->work);
> 		} else {
>+			// depending on the vfree_atomic() branch in vfree()
same as above.

> 			bpf_prog_put_deferred(&aux->work);
> 		}
> 	}
>--
>2.25.1