netdev - Re: udp_tunnel patch("udp_tunnel: add central NIC RX port offload infrastructure")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Tue, 30 May 2023 10:37:39 +0530
From: Somnath Kotur <somnath.kotur@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org
Subject: Re: udp_tunnel patch("udp_tunnel: add central NIC RX port offload infrastructure")

On Sat, May 27, 2023 at 5:48 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 26 May 2023 11:51:42 +0530 Somnath Kotur wrote:
> > Firstly, do you think that this is a bug in the code? Should we get rid of
> > this 'entry->use_cnt' check inside _udp_tunnel_nic_get_port() or some other
> > fix needed?  OR Was this intended as part of the design?
>
> I think the comment in udp_tunnel_nic_get_port() should have the answer:
>
> https://elixir.bootlin.com/linux/v6.4-rc1/source/include/net/udp_tunnel.h#L310
>
> there are two APIs driver can implement - the "table sync" one which
> doesn't know the port when it's deleted, and "add/del port" which
> gets called with more info.
>
> You can switch to the other API or possibly use the bp->vxlan_port
> and bp->nge_port ports?
>
Sure, thanks Kuba

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)