netdev - Re: [PATCH v8 2/3] net: dsa: mv88e6xxx: add support for MV88E6020 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 31 May 2023 10:08:28 +0200
From: Lukasz Majewski <lukma@...x.de>
To: Florian Fainelli <f.fainelli@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
 Russell King <linux@...linux.org.uk>, Eric Dumazet <edumazet@...gle.com>,
 "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Alexander Duyck
 <alexander.duyck@...il.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, Matthias Schiffer
 <matthias.schiffer@...tq-group.com>
Subject: Re: [PATCH v8 2/3] net: dsa: mv88e6xxx: add support for MV88E6020
 switch

Hi Florian,

> On 5/30/23 01:39, Lukasz Majewski wrote:
> > From: Matthias Schiffer <matthias.schiffer@...tq-group.com>
> > 
> > A mv88e6250 family switch with 2 PHY and RMII ports and
> > no PTP support.
> > 
> > Signed-off-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>
> > Signed-off-by: Lukasz Majewski <lukma@...x.de>
> > Reviewed-by: Andrew Lunn <andrew@...n.ch>  
> 
> > ---  
> [snip]
> 
> >   /* List of supported models */
> >   enum mv88e6xxx_model {
> > +	MV88E6020,
> >   	MV88E6085,
> >   	MV88E6095,
> >   	MV88E6097,
> > @@ -94,7 +95,7 @@ enum mv88e6xxx_family {
> >   	MV88E6XXX_FAMILY_6097,	/* 6046 6085 6096 6097 */
> >   	MV88E6XXX_FAMILY_6165,	/* 6123 6161 6165 */
> >   	MV88E6XXX_FAMILY_6185,	/* 6108 6121 6122 6131 6152
> > 6155 6182 6185 */
> > -	MV88E6XXX_FAMILY_6250,	/* 6220 6250 */
> > +	MV88E6XXX_FAMILY_6250,	/* 6220 6250 6020 */  
> 
> über nit: only if you have to resubmit, numbers in ascending order.
> 

I hope that v8 will be the last iteration :-)

> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@...x.de

Content of type "application/pgp-signature" skipped